Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: Graph navigation keys #13403

Open
radare opened this issue Mar 17, 2019 · 6 comments
Open

RFE: Graph navigation keys #13403

radare opened this issue Mar 17, 2019 · 6 comments

Comments

@radare
Copy link
Collaborator

radare commented Mar 17, 2019

There are some things that will be interesting to have in the interactive graph view:

  • Scroll/seek to the first block (entry)
  • Iterate over all the blocks that have no out edges (end/exit nodes)
  • Iterate over all the blocks that have a jump back out edge (loops)
  • Iterate over all nodes that have more than 2 out-edges (jump tables)

We can probably show that in a list in the left side of the screen with "points of interest" for the current graph

@radare radare added good first issue RGraph visual Visual console mode (NOT PANELS!) labels Mar 17, 2019
@radare radare added this to the 3.4.0 - codename "hufflepuff" milestone Mar 17, 2019
@penthaapatel
Copy link

Hello! New contributor here. I would like to work on this issue. Should the features be added to libr/core/visual.c file? Can I get more guidance on how to proceed with adding these features?

@radare
Copy link
Collaborator Author

radare commented Mar 17, 2019 via email

@radare
Copy link
Collaborator Author

radare commented Mar 25, 2019

We shouhld first stsart implementing a verbose list of basic blocks in afbl with columns displaying amount of input/output edges so we can use ~$ for sorting them and use that from the vb +hud in an r2 oneliner to select the node. that should be enough for solving this problem in few lines

@radare
Copy link
Collaborator Author

radare commented Mar 29, 2019

i did last week the 'b' handling in graph, so we can consider this issue is "solved" but we need to implement the afbl command, which is pretty easy to do

@radare radare modified the milestones: 3.4.0, 3.5.0 Apr 1, 2019
@radare radare changed the title Graph navigation keys RFE: Graph navigation keys Apr 1, 2019
@radare radare added this to To do in Console Interface Improvements via automation Apr 17, 2019
@radare
Copy link
Collaborator Author

radare commented May 9, 2019

i did some work on this with the i and I keys. as long as i got 0 feedback ill move to 3.6

@radare radare modified the milestones: 3.5.0, 3.6.0 May 9, 2019
@radare
Copy link
Collaborator Author

radare commented Jun 17, 2019

@Vane11ope maybe related to panels to improve graph navigation support in there? any comments here?

@radare radare modified the milestones: 3.6.0, 3.7.0 Jun 20, 2019
@XVilka XVilka modified the milestones: 3.7.0, 3.8.0 - after r2con Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants