Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problematic analysis options #13482

Closed
radare opened this issue Mar 24, 2019 · 11 comments
Closed

Problematic analysis options #13482

radare opened this issue Mar 24, 2019 · 11 comments
Assignees
@trufae
Labels
RAnal test-required
Projects
Analysis
Milestone
5.3.0

Comments

@radare
Copy link
Collaborator

radare commented Mar 24, 2019 •
edited 

[0x00005310]> e anal.jmp.after =0

setting this results in pretty fuckedup analysis, we may probably want to remove some of those options or remove the code paths that cause this
@radare radare added this to the 3.4.0 milestone Mar 25, 2019
@radare
Copy link
Collaborator Author

radare commented Mar 29, 2019

i think anal.jmp.eob can be removed, but i need to read some more code to get a decision on this, feedback is welcome

@XVilka
Copy link
Contributor

XVilka commented Mar 29, 2019

Maybe postpone this for 3.5.0 instead?

@radare radare modified the milestones: 3.4.0, 3.5.0 Mar 29, 2019
@Maijin
Copy link
Contributor

Maijin commented Mar 31, 2019

Can you please provide details on what is "fucked-up" and reproducers files and commands?

@radare
Copy link
Collaborator Author

radare commented Mar 31, 2019

lots of broken edges and invalid bb boundaries basically

Screenshot 2019-03-31 at 13 58 26

@Maijin
Copy link
Contributor

Maijin commented Mar 31, 2019

When you have time can you provide files and commands for this?

@radare
Copy link
Collaborator Author

radare commented Apr 17, 2019

/bin/ls from mojave, set those options, aaa and open graph in visual

@Maijin
Copy link
Contributor

Maijin commented Apr 17, 2019

Here is the binary -
ls.zip

@Maijin
Copy link
Contributor

Maijin commented Apr 19, 2019

For eob the only issue that needed it was this one maybe now it's working by default and therefore the eval can be removed - #4258 (comment) to be tested

@radare radare modified the milestones: 3.5.0, 3.6.0 May 7, 2019
@radare radare modified the milestones: 3.6.0, 3.7.0 Jun 17, 2019
@XVilka XVilka modified the milestones: 3.7.0, 3.8.0 - after r2con Jul 30, 2019
@XVilka XVilka added this to To do in Analysis via automation Jul 30, 2019
@XVilka XVilka modified the milestones: 3.9.0, 4.0.0 Sep 14, 2019
radare added a commit that referenced this issue Oct 23, 2019
@radare
Deprecate anal.jmp.eob /refs #13482 ##anal
3ecc70e
@radare
Copy link
Collaborator Author

radare commented Oct 23, 2019

#15340

radare added a commit that referenced this issue Oct 23, 2019
@radare
Deprecate anal.jmp.eob /refs #13482 ##anal (#15340)
0652073
@radare radare modified the milestones: 4.0.0, 4.1.0 Oct 26, 2019
@ghost ghost mentioned this issue Nov 9, 2019
Closed
@radare
Copy link
Collaborator Author

radare commented Jan 17, 2020

cc @thestr4ng3r

@radare radare modified the milestones: 4.3.0, 4.5.0 Mar 2, 2020
@ret2libc ret2libc removed their assignment Apr 22, 2020
@XVilka XVilka modified the milestones: 4.5.0 - Organized Chaos, 4.6.0 May 21, 2020
@trufae trufae assigned trufae and unassigned Maijin and thestr4ng3r Apr 25, 2021
@trufae
Copy link
Collaborator

trufae commented May 11, 2021

I removed those variables, so this is no longer an issue

@trufae trufae closed this as completed May 11, 2021
Analysis automation moved this from To do to Done May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trufae trufae

Labels
RAnal test-required
Projects
Analysis
  
Done
Milestone
5.3.0
Development

No branches or pull requests
6 participants
@XVilka @ret2libc @radare @Maijin @thestr4ng3r @trufae