Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ~... highlights ascii control characters #14197

Closed
alex-bender opened this issue May 31, 2019 · 11 comments
Closed

The ~... highlights ascii control characters #14197

alex-bender opened this issue May 31, 2019 · 11 comments

Comments

@alex-bender
Copy link
Contributor

alex-bender commented May 31, 2019

Steps to reproduce:

r2 /bin/ls
pd~...
>m

got this

 -             �[38;2;208;80;0m;-- entry0:�[0m                                                                                                                                                              rip:                                                                                                                                                                  
               �[38;2;208;80;0m;-- rip:�[0m                                                                                                                                                                0005852      4989d1         mov r9, rdx                                                                                                                                
               �[7m�[38;2;160;160;160m0x00005850�[0m      �[38;2;208;208;192m31�[38;2;160;160;160med�[0m           �[38;2;240;192;176mxor�[38;2;128;208;208m ebp�[0m,�[38;2;128;208;208m�[38;2;128;208;208m ebp�[0m�[0m�[0m                                                                                                                                                       
               �[38;2;160;160;160m0x00005852�[0m      �[38;2;208;208;192m49�[38;2;160;160;160m89�[38;2;160;160;160md1�[0m         �[38;2;192;208;144mmov�[38;2;128;208;208m r9�[0m,�[38;2;128;208;208m�[38;2;128;208;208m rdx�[0m�[0m�[0m                                                                                                                                         
               �[38;2;160;160;160m0x00005855�[0m      �[38;2;208;208;192m5e�[0m             �[38;2;240;240;192mpop�[38;2;128;208;208m rsi�[0m�[0m�[0m                                       

radare2 3.6.0-git 1942 @ linux-x86-64 git.3.5.1-139-g99502ef5
commit: 99502ef build: 2019-05-31__14:00:59

there is no problem in that version:
radare2 3.5.0-git 1508 @ linux-x86-64 git.3.4.1-409-g7d158e4
commit: 7d158e4 build: 2019-05-11__20:12:16

@XVilka XVilka added this to the 3.7.0 milestone Jun 17, 2019
@XVilka XVilka added the bug label Jun 17, 2019
@XVilka XVilka added this to To do in Console Interface Improvements via automation Jul 30, 2019
@radare radare modified the milestones: 3.7.0, 3.8.0 - after r2con Jul 31, 2019
@XVilka
Copy link
Contributor

XVilka commented Aug 18, 2019

Should be fixed now. Reopen if not.

@XVilka XVilka closed this as completed Aug 18, 2019
Console Interface Improvements automation moved this from To do to Done Aug 18, 2019
@alex-bender
Copy link
Contributor Author

Looks like not yet

@XVilka
Copy link
Contributor

XVilka commented Aug 18, 2019

Need more details on environment then

@alex-bender
Copy link
Contributor Author

r2 -v
radare2 3.7.1 22562 @ linux-x86-64 git.3.7.1-24-ge1cf65332
commit: e1cf653 build: 2019-08-18__19:56:30

After exit I can't select anything in terminal without pressing Shift key

@alex-bender
Copy link
Contributor Author

OS: Ubuntu 18.04.2 LTS
Terminal: GNOME Terminal 3.28.2
bash --version
GNU bash, version 4.4.20(1)-release (x86_64-pc-linux-gnu)

@alex-bender
Copy link
Contributor Author

Actually I have the same behavior even in tty, so I don't think that pts is involved.

@radare radare reopened this Aug 19, 2019
Console Interface Improvements automation moved this from Done to In progress Aug 19, 2019
@radare
Copy link
Collaborator

radare commented Aug 19, 2019

I can repro @deepakchethan

@radare radare modified the milestones: 3.8.0, 3.9.0 Sep 1, 2019
@radare
Copy link
Collaborator

radare commented Sep 15, 2019

ping @deepakchethan

@radare radare modified the milestones: 3.9.0, 4.0.0 Sep 16, 2019
@alex-bender
Copy link
Contributor Author

mouse click also introduces problems

@radare
Copy link
Collaborator

radare commented Oct 3, 2019 via email

@alex-bender
Copy link
Contributor Author

Sure. After pd~... any click results in color chars being printed

0> 0;34;3M0;34;3m0;9;2M0;9;2m|

terminal is GNOME Terminal 3.28.2

@radare radare removed this from the 4.0.0 milestone Oct 27, 2019
@radare radare added this to the 4.1.0 milestone Oct 27, 2019
GustavoLCR added a commit to GustavoLCR/radare2 that referenced this issue Dec 7, 2019
@radare radare closed this as completed in 54c8929 Dec 7, 2019
Console Interface Improvements automation moved this from In progress to Done Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants