-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve realname support for symbols #15702
Conversation
Could you please also add a few tests? |
What do you think of this direction? before we start the work on all plugins |
libr/bin/p/bin_pe.inc
Outdated
@@ -227,7 +228,8 @@ static RList* symbols(RBinFile *bf) { | |||
break; | |||
} | |||
//strncpy (ptr->name, (char*)symbols[i].name, R_BIN_SIZEOF_STRINGS); | |||
ptr->name = r_str_newf ("imp.%s", imports[i].name); | |||
ptr->name = r_str_newf ("%s", imports[i].name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strdup?
I’m very in favor of this change! I like it |
If the user will see A suggested seek mechanism can be found below: If only one flag contains this substring (e.g. only If there are more then one option, then r2 will show:
|
iij should contain flagname |
pls rebase |
+1 for this
… On 2 Jan 2020, at 15:52, Itay Cohen ***@***.***> wrote:
If the user will see call LoadLibraryA we need to find a way to let users know how to navigate to this because s LoadLibraryA won't work. What do you think?
A suggested seek mechanism can be found below:
If only one flag contains this substring (e.g. only imp.kernel32_dll.LoadLibraryA will contain LoadLibraryA), then the seek will be to this address.
If there are more then one option, then r2 will show:
The flag 'LoadLibraryA' wasn't found. Did you mean to one of the following flags that contain this substring:
0x4001234 imp.kernel32_dll.LoadLibraryA
0x7e01133 imp.someOther_dll.LoadLibraryA
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@@ -1704,12 +1709,12 @@ static int bin_relocs(RCore *r, int mode, int va) { | |||
} | |||
|
|||
#define MYDB 1 | |||
/* this is a hacky workaround that needs proper refactoring in Rbin to use Sdb */ | |||
/* this is a VERY VERY VERY hacky and bad workaround that needs proper refactoring in Rbin to use Sdb */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lollll
There is a slight difference in flagnames with demangling currently:
this pr:
Note that the |
I completely agree :) |
2cdb389
to
373cb8a
Compare
Please rebase on top of the currently green master, thanks! |
bcb135e
to
e2a89f6
Compare
0127c04
to
b29da94
Compare
These changes aim to modify the way symbols are structured and look on the disassembly and across different places. More specifically, when
asm.flags.real
is set to true.For example, this PR is aimed to change this:
To this:
In addition, it also adds the "libname" to each import. In general, it improves consistency across symbols in r2.