Smart correction of flags usage

[ITAYC0HEN]

Is your feature request related to a problem? Please describe.

As a result of #15702, the disassembly will change how flags are displayed:

For example, this:

call  dword   [sym.imp.user32.dll_CreateWindowExA]

To this:

call CreateWindowExA

Thus, users will try to use CreateWindowExA as the name of the flags in their commands.
Things like s CreateWindowExA or pdf @ CreateWindowExA. This will not work for them because this is not the name of the flag.

Describe the solution

Say the user will want to do s LoadLibraryA or pdf @ LoadLibraryA, radare2 will behave like this:

If only one flag contains this substring in its name or in its realname (e.g. only imp.kernel32_dll.LoadLibraryA will contain LoadLibraryA), then the seek will be to this address. There is no doubt that this is what the user expects so it's an easy decision and we can simply apply it for them.

If there are more then one option, then r2 will show something like this:

Multiple flags matched 'LoadLibraryA'. Did you mean to one of the following flags that contain this string:
0x4001234    imp.kernel32_dll.LoadLibraryA
0x7e01133    imp.someOther_dll.LoadLibraryA

This change will help in other cases as well and make the usage more friendly

[radare]

this is fixed now in master, or at least pretty improved after asm.flags.real but we need to have realname field in functions to not conflict with the function renamings

[radare]

@ITAYC0HEN can we close this issue?

[ITAYC0HEN]

i don't think we touched this issue yet?
This issue will require another hashtable for flag realnames in order to quickly search for the right flag.

The idea is that when a user will use realname and see something like "call VirtualAlloc" they will be able to perform "s VirtualAlloc" without having to specify the whole "sym.imp.kernel32_dll" thing.

A usage of a string (flag) in command will go this way:

1. string == flag name
2. string == flag real name
3. string contained in flag name

so if the user will do

pd 3 @ sym.imp.user32.dll_CreateWindowExA + 5

then it's easy, r2 will behave is it behaves now.
But if it will do

pd 3 @ CreateWindowExA + 5

then we want r2 to understand it as well.

this thoroughly describe in the issue. read carefully.

[radare]

Ok then moving fwd

…

On 17 Jan 2020, at 14:08, Itay Cohen ***@***.***> wrote:  i don't think we touched this issue yet? This issue will require another hashtable for flag realnames in order to quickly search for the right flag. The idea is that when a user will use realname and see something like "call VirtualAlloc" they will be able to perform "s VirtualAlloc" without having to specify the whole "sym.imp.kernel32_dll" thing. A usage of a string (flag) in command will go this way: string == flag name string == flag real name string contained in flag name so if the user will do pd 3 @ sym.imp.user32.dll_CreateWindowExA + 5 then it's easy, r2 will behave is it behaves now. But if it will do pd 3 @ CreateWindowExA + 5 then we want r2 to understand it as well. this thoroughly describe in the issue. read carefully. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[radare]

Kind of related to #12064