Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rbtree implementation #19252

Closed
condret opened this issue Oct 18, 2021 · 4 comments
Closed

Replace rbtree implementation #19252

condret opened this issue Oct 18, 2021 · 4 comments
Assignees
Labels
API New API requests, changes, removal hardcore Extremely hard issues to fix, or features to implement
Milestone

Comments

@condret
Copy link
Member

condret commented Oct 18, 2021

Current rbtree implementation has some issues with UAF after using the delete function.
It would be more desirable to fix that, but let's face it: Nobody in the dev-community has the gigachad brain to understand this compactly written piece of code in all details and it's effectively unmaintainable for us.

https://github.com/leiless/jw_rbtree this implementation looks much more simple, clean and seems easier to understand.

Befor start porting it, here are some rules:

  • no single character varnames
  • keep complexity as low as possible

I'll do the port, @radare pls do the review later

@condret condret added hardcore Extremely hard issues to fix, or features to implement API New API requests, changes, removal labels Oct 18, 2021
@condret condret added this to the 5.5.0 milestone Oct 18, 2021
@condret condret self-assigned this Oct 18, 2021
@condret
Copy link
Member Author

condret commented Oct 19, 2021

condret added a commit to condret/radare2 that referenced this issue Oct 20, 2021
@condret condret modified the milestones: 5.5.0, Attic Oct 21, 2021
@trufae
Copy link
Collaborator

trufae commented Oct 21, 2021

Thats merged. Good job

@trufae trufae closed this as completed Oct 21, 2021
@trufae
Copy link
Collaborator

trufae commented Oct 21, 2021

Now its time to replace the old one

@condret
Copy link
Member Author

condret commented Oct 21, 2021

I set the milestone to attic, bc replacing all occassions of the old api may take a looooong time

aemmitt-ns pushed a commit to aemmitt-ns/radare2 that referenced this issue Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API New API requests, changes, removal hardcore Extremely hard issues to fix, or features to implement
Projects
None yet
Development

No branches or pull requests

2 participants