Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panels Mode: Top menu bug #19409

Closed
PROPHESSOR opened this issue Nov 15, 2021 · 5 comments
Closed

Panels Mode: Top menu bug #19409

PROPHESSOR opened this issue Nov 15, 2021 · 5 comments
Assignees
Milestone

Comments

@PROPHESSOR
Copy link

Environment

prophessor@prophessor-X555LJ ~> date
Пн ноя 15 15:41:07 EET 2021
prophessor@prophessor-X555LJ ~> r2 -v # v5.5.0 master, has the bug
radare2 5.5.0 1 @ linux-x86-64 git.
commit: eb301fdea05654a749f8014166aefa915ea7e6ff build: 2021-11-15__15:24:46
prophessor@prophessor-X555LJ ~> /usr/bin/r2 -v # v4.3.1 doesn't have the bug
radare2 4.3.1 0 @ linux-x86-64 git.4.3.1
commit: HEAD build: 2020-03-06__15:05:41
prophessor@prophessor-X555LJ ~> uname -ms
Linux x86_64

Description

In the master version, it is impossible to switch between the tabs of the top menu. Also, when choosing a view mode, the menu does not close. See video in ## Test for details

Test

https://youtu.be/96bSZKSCdBc

@PROPHESSOR PROPHESSOR changed the title Visual Mode: Top menu bug Panels Mode: Top menu bug Nov 16, 2021
@trufae trufae self-assigned this Nov 22, 2021
@trufae trufae added this to the 5.5.2 milestone Nov 22, 2021
@trufae
Copy link
Collaborator

trufae commented Dec 5, 2021

The top menu is unfocused when pressing the 'm' key to toggle menu access or pressing the tab key to select a different panel. not sure if i understand the issue you are having here, but maybe it's not an issue :?

@trufae trufae modified the milestones: 5.5.2, 5.6.0 Dec 5, 2021
@trufae
Copy link
Collaborator

trufae commented Dec 21, 2021

ping?

@PROPHESSOR
Copy link
Author

PROPHESSOR commented Dec 29, 2021

@trufae There are two bugs:

  1. You can't move to menu's header by pressing up arrow key like it was in v4.3.1
  2. In the video after changing view to Breakpoints the menu is still on the screen. It looks like missed repaint call, so you need open menu again to re-render and hide it. v4.3.1 doesn't have this issue.

P.S> Sorry for the delay, I didn’t receive a notification

@trufae trufae modified the milestones: 5.6.0, 6.0.0 Jan 21, 2022
@trufae trufae closed this as completed in fe900e0 Feb 1, 2022
@trufae
Copy link
Collaborator

trufae commented Feb 1, 2022

sorry for the delay again, was busy as hell catching other bugs. from what i understand.

  1. this is expected, the old behaviour was wrong imho.
  2. fixed

brainstorm pushed a commit to brainstorm/radare2 that referenced this issue Feb 13, 2022
@PROPHESSOR
Copy link
Author

  1. It's not convenient to move through menus in this case. For example, in the case of new behaviour pressing right arrow will open Colors submenu instead of moving to Edit tab.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants