Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping nodes #41

Open
radare opened this issue Jul 14, 2015 · 10 comments
Open

Grouping nodes #41

radare opened this issue Jul 14, 2015 · 10 comments
Labels

Comments

@radare
Copy link

radare commented Jul 14, 2015

Merging two or more nodes from the ascii art graph would be very useful, the idea behind this feature consists in the following:

  • Add a key to toggle node compactness.
  • We want to have more than one group
  • Maybe we can just tag each block with a keyword and assign a random color to every tag to print the block box.
  • Then add a key to group/ungroup all blocks with the same tag as the currently selected one.
  • We can automatically add those tags to entry/exit/math/loop/...
  • Graph should be relayouted after the grouping operation happens.
  • Grouped nodes can have more than one in and out edges
@ret2libc
Copy link

ret2libc commented Sep 8, 2015

I think we should delay this. I won't be able to do it soon.

@radare
Copy link
Author

radare commented Sep 8, 2015

Moved to 1.0

@ret2libc ret2libc removed their assignment May 22, 2016
@radare
Copy link
Author

radare commented Dec 18, 2016

We can use the 'T' and 'F' keys to merge the TRUE and FALSE nodes to the current one. and maybe use U to undo the operation

@alvarofe
Copy link

'U' is already use for redo seek

@radare
Copy link
Author

radare commented Dec 19, 2016 via email

@radare
Copy link
Author

radare commented Dec 19, 2016

I have an idea for this and will be easier than i though... but not today.moving to 1.2

@XVilka
Copy link
Contributor

XVilka commented May 17, 2018

@cyanpencil please check this one too, if you have an idea how to implement this quickly. If not - then I think you already have more than enough.

@radare
Copy link
Author

radare commented Aug 31, 2018

maybe good to have some feedback from @xarkes because that may be good to be supported in Cutter too. We can manually merge basic blocks in the analysis information. so maybe this is a solution, but this will affect more things than just the way we display the graph. So i would prefer to make this thing just happen in visual, and be able to save/restore graph layouts (and merged/grouped) nodes)

@ret2libc
Copy link

This issue has been moved from radareorg/radare2 to radareorg/ideas as we are trying to clean our backlog and this issue has probably been created a long while ago. This is an effort to help contributors understand what are the actionable items they can work on, prioritize issues better and help users find active/duplicated issues more easily. If this is not an enhancement/improvement/general idea but a bug, feel free to ask for re-transfer to main repo. Thanks for your understanding and contribution with this issue.

@ret2libc ret2libc transferred this issue from radareorg/radare2 Jun 23, 2020
@XVilka XVilka added the RGraph label Jul 1, 2020
@XVilka
Copy link
Contributor

XVilka commented Oct 19, 2020

@karliss you might be interested in this issue long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants