Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong jump instruction decoding for 16bit assembly. #83

Closed
XVilka opened this issue Apr 28, 2013 · 1 comment
Closed

Wrong jump instruction decoding for 16bit assembly. #83

XVilka opened this issue Apr 28, 2013 · 1 comment

Comments

@XVilka
Copy link
Contributor

XVilka commented Apr 28, 2013

Do this for image http://xvilka.me/ami_bios.bin

  1. r2 -e asm.bits=16 -e io.va=true ami_bios.bin
  2. S $s-0x10000 0xf000:0x0000 0x10000 0x10000 bootblk rwx
  3. e asm.segoff=true
  4. s 0xf000:0xffaa
  5. pd 1
    It show:
    f000:ffaa e99300 jmp 0x100040
    while it should be:
    f000:ffaa e99300 jmp 0x40
@radare
Copy link
Collaborator

radare commented Apr 28, 2013

I did a test case in r2-regressions to track this issue.

https://github.com/vext01/r2-regressions/commit/47966adc8f4646fad9e96fda7b63eb7da1adf5a0

This bug appeared again because of a bug in udis86 that was fixed by my patches and has reapered after re-merging udis86 from git. Will do port the fix and report the author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants