Kill the _end section flags and fix flag size

[radare]

Fix #11348

[radare]

the XX look good to me, updating them should be harmless. Also noticed some improvements.

[ret2libc]

LGTM

[ret2libc]

of course after fixing tests :D

[radare]

yep :P if anyone in the mood :P

…

On 3 Sep 2018, at 10:11, Riccardo Schirone ***@***.***> wrote: of course after fixing tests :D — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11349 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lgIn9NrZchYjYJKFXSlxqz5pmDJQks5uXOQlgaJpZM4WWa5q>.

[kazarmy]

Some people are going to miss those _end flags since:

1. The alternative of section..<section> + $s{section..<section>} is less convenient.
2. It would be nice to have a visual indicator of the section you're entering when moving backwards in Visual mode.

Regarding the above, it might be better to have an asm config var to show all flags at an address.

[ret2libc]

It would be nice to have a visual indicator of the section you're entering when moving backwards in Visual mode.

that's true, though I think things should be displayed based on flag starting address + flag size, instead of having two flags as it is right now in master.

[kazarmy]

might be tricky to implement efficiently but ok

[radare]

because i think its easier to improve the RNumCallback to handle $$flagname for this

[0x100001200]> ?v $$section.2.__TEXT.__stub_helper
0x100004900
[0x100001200]> ?v section.2.__TEXT.__stub_helper
0x1000045f8
[0x100001200]>

i have a bunch of suggestions and ideas to improve the syntax for those numbers

[radare]

moved to $e{}

[0x100001200]> ?v section.0.__TEXT.__text
0x100000f20
[0x100001200]> ?v $e{section.0.__TEXT.__text}
0x10000442e
[0x100001200]> ?v $s{section.0.__TEXT.__text}
0x350e
[0x100001200]>

[radare]

the _end flags introduce issues in disasm because it takes the _end instead of the next begin one and such, which use cases do people have for the _end flags? because i think with that $e{} is enough

[Maijin]

The e{} Sgtm

[XVilka]

Agree, we just need add this into the Sections chapter of r2book.

…

On Thu, Sep 13, 2018, 5:06 PM Maijin ***@***.***> wrote: The e{} Sgtm — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11349 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMZ_UMxl9UzQwDvXhxFofg3b6OZqOxCks5uah_9gaJpZM4WWa5q> .

[radare]

ok, rebasing and updating tests for the glory of the merge

[radare]

before adding this to the book i would prefer to discuss all the ?$? vars