Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #13190 - remove sz from classlisting #13238

Merged
merged 1 commit into from Mar 8, 2019

Conversation

c-urly
Copy link
Contributor

@c-urly c-urly commented Mar 2, 2019

deleted the "sz" from classlisting.

@ret2libc
Copy link
Contributor

ret2libc commented Mar 2, 2019

What are the reasons for this?

@radare
Copy link
Collaborator

radare commented Mar 3, 2019

Ease the grepping, and remove clutter

@radare radare changed the title remove sz from classlisting Fix #13190 Fix #13190 - remove sz from classlisting Mar 3, 2019
@radare
Copy link
Collaborator

radare commented Mar 3, 2019

If we all agree the new output looks better it may just update the tests and it can be merged.

@c-urly
Copy link
Contributor Author

c-urly commented Mar 3, 2019

For tarvis to succeed we have to remove "sz" from test suite?

@ret2libc
Copy link
Contributor

ret2libc commented Mar 3, 2019

oki

@radare
Copy link
Collaborator

radare commented Mar 3, 2019

Use bin/r2r.js -i ...

Fix the outputs , submit a pr in r2r with the same name as this one and rebase this pr to get travis rerun the thing

@radare
Copy link
Collaborator

radare commented Mar 4, 2019

ping

@radare
Copy link
Collaborator

radare commented Mar 6, 2019

please send a pr in r2r and rebase

@radare
Copy link
Collaborator

radare commented Mar 8, 2019

ping

@radare radare merged commit fc63cda into radareorg:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants