Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include aap in aaa #13543

Merged
merged 3 commits into from Mar 29, 2019
Merged

Include aap in aaa #13543

merged 3 commits into from Mar 29, 2019

Conversation

deepakchethan
Copy link
Contributor

Closes #13503

After Image:
Screen Shot 2019-03-29 at 8 52 48 AM

@Maijin
Copy link
Contributor

Maijin commented Mar 29, 2019

I wouldn't have aap in aaa for recognized fileformat, only when you open a binary without file format imho that would make sense.

@deepakchethan
Copy link
Contributor Author

I wouldn't have aap in aaa for recognized fileformat, only when you open a binary without file format imho that would make sense.

I just followed what was mentioned in issue #13503. I will make the change and push it in some time :)

@radare
Copy link
Collaborator

radare commented Mar 29, 2019 via email

Copy link
Collaborator

@radare radare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

libr/core/cmd_anal.c Outdated Show resolved Hide resolved
@radare
Copy link
Collaborator

radare commented Mar 29, 2019 via email

@deepakchethan
Copy link
Contributor Author

deepakchethan commented Mar 29, 2019

yes i know but this variable should disapear because it makes no sense if yoh ave multiple binaries loaded

On 29 Mar 2019, at 12:37, Deepak Chethan @.***> wrote: I made the change. If the file type is unknown, then e file.type will return an empty string. https://user-images.githubusercontent.com/20895544/55230175-00bb3280-5245-11e9-9cbd-113ee875c589.png — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13543 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-liVCAesPXkwIFQmrOSw95qM8B96Sks5vbfrhgaJpZM4cRjRn.

I wrote that before I saw your review. I will make changes and push soon :)

EDIT: Done making the changes

The output for current version:

Screen Shot 2019-03-29 at 9 47 37 PM

@radare radare merged commit 20b56ef into radareorg:master Mar 29, 2019
@deepakchethan deepakchethan mentioned this pull request Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants