Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance drm command, add drm xmm0 functionality #15214

Merged
merged 8 commits into from Oct 10, 2019

Conversation

koyaan
Copy link
Contributor

@koyaan koyaan commented Oct 7, 2019

@radare
Copy link
Collaborator

radare commented Oct 7, 2019

i was thinking in supporting this in the r2 way.. so using a subcommand of drm instead of a special syntax for the arg. like: drmw drmh, drmq.. what do you think?

thanks for the contrib!

@koyaan
Copy link
Contributor Author

koyaan commented Oct 7, 2019

That is a good idea, i will try to implement that! Is there a way to alias for example dmmb xmm0 to dmm xmm0 * 8 or should I remove the wildcard functionality?

@radare
Copy link
Collaborator

radare commented Oct 7, 2019 via email

@koyaan
Copy link
Contributor Author

koyaan commented Oct 7, 2019

No I was just looking for way to have index unspecified while specifying a size without breaking existing functionality.

@radare
Copy link
Collaborator

radare commented Oct 8, 2019

then i would go for just supporting the r2 subcommand way which is more consistent with the rest of r2

@koyaan
Copy link
Contributor Author

koyaan commented Oct 8, 2019

I added the shorthand versions now, also updated tests.

Copy link
Collaborator

@radare radare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

.ipynb_checkpoints/Untitled-checkpoint.ipynb Outdated Show resolved Hide resolved
@@ -144,28 +144,36 @@ return strdup (
"fpu st6 .64 128 0\n"
"fpu st7 .64 144 0\n"

"fpu xmm0h .64 160 0\n"
"fpu xmm0l .64 168 0\n"
"fpu xmm0 .64 160 16\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u update the other x64 profiles. Too? Not just the linux one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which ones? Windows does its own thing for example

kyn-vectors.md Outdated Show resolved Hide resolved
libr/core/cmd_debug.c Outdated Show resolved Hide resolved
libr/core/cmd_debug.c Outdated Show resolved Hide resolved
@koyaan
Copy link
Contributor Author

koyaan commented Oct 9, 2019

Removed accidental files, and adjusted C-style, also added [?] indicator to help

@koyaan
Copy link
Contributor Author

koyaan commented Oct 9, 2019

now mmx registers also work as expected

[0x004000b0]> drm mm0
0x00 0x70 0xa0 0x8a 0x36 0xfd 0xec 0x91
0x7000 0x8aa0 0xfd36 0x91ec
0x8aa07000 0x91ecfd36
0x91ecfd368aa07000

@radare radare merged commit 9b9103e into radareorg:master Oct 10, 2019
@radare
Copy link
Collaborator

radare commented Oct 10, 2019

The changes proposed looks good to me. Thanks!!

@koyaan koyaan deleted the enhance_cmd_drm branch October 10, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants