New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance drm
command, add drm xmm0
functionality
#15214
Conversation
2dee794
to
74f73bd
Compare
i was thinking in supporting this in the r2 way.. so using a subcommand of drm instead of a special syntax for the arg. like: drmw drmh, drmq.. what do you think? thanks for the contrib! |
That is a good idea, i will try to implement that! Is there a way to alias for example |
you can call the same command again with the wildcard syntax from the subcommand one if you like this way it will support both syntaxes.. is this a gdb thing ?
… On 7 Oct 2019, at 12:30, Armin Weihbold ***@***.***> wrote:
That is a good idea, i will try to implement that! Is there a way to alias for example dmmb xmm0 to dmm xmm0 * 8 or should I remove the wildcard functionality?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#15214?email_source=notifications&email_token=AAG75FQ2RHTQ63HNCA5H323QNMFU3A5CNFSM4I56PJ7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAPZLEA#issuecomment-538940816>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAG75FU3Y44R2MOGRFYZQMDQNMFU3ANCNFSM4I56PJ7A>.
|
No I was just looking for way to have index unspecified while specifying a size without breaking existing functionality. |
then i would go for just supporting the r2 subcommand way which is more consistent with the rest of r2 |
I added the shorthand versions now, also updated tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@@ -144,28 +144,36 @@ return strdup ( | |||
"fpu st6 .64 128 0\n" | |||
"fpu st7 .64 144 0\n" | |||
|
|||
"fpu xmm0h .64 160 0\n" | |||
"fpu xmm0l .64 168 0\n" | |||
"fpu xmm0 .64 160 16\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u update the other x64 profiles. Too? Not just the linux one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which ones? Windows does its own thing for example
Removed accidental files, and adjusted C-style, also added [?] indicator to help |
now mmx registers also work as expected
|
The changes proposed looks good to me. Thanks!! |
This is for the proposal in #15213
Tests: https://github.com/radareorg/radare2-regressions/pull/1977