Replace r_str_const* with RStrConstPool #15300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
force-pushed
the
str-constpool
branch
from
a39a162
to
db2ecf3
Compare
|
These are many commits, but I think they still should NOT be squashed because this makes bisecting easier in case of breakage. |
thestr4ng3r
force-pushed
the
str-constpool
branch
2 times, most recently
from
20bb228
to
4c532b3
Compare
thestr4ng3r
force-pushed
the
str-constpool
branch
from
4c532b3
to
b920887
Compare
|
Probably stupid question, but what's the purpose of |
|
It keeps a set of constant strings and if you ask for one, it will either return the matching existing one or create a new one and return that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.