Improve macOS installation documentation #15438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid ambiguous signing certificates on macOS. If a user manually installed a new code signing certificate into the login keychain as documented, the install script will fail to sign r2 because the `sys/macos-cert.sh` script generates a new certificate in the System keychain. This results in the following error when signing: ``` org.radare.radare2: ambiguous (matches "org.radare.radare2" in /Users/user/Library/Keychains/login.keychain-db and "org.radare.radare2" in /Library/Keychains/System.keychain) ``` To be constistent with `sys/macos-cert.sh`, change manual certificate generation steps to install to System keychain instead of login keychain. Mention that code signing certificate generation is automated by the install script before listing the manual steps to generate a new code signing certificate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid ambiguous signing certificates on macOS.
If a user manually installed a new code signing certificate into the
login keychain as documented, the install script will fail to sign r2
because the
sys/macos-cert.shscript generates a new certificate inthe System keychain. This results in the following error when signing:
To be constistent with
sys/macos-cert.sh, change manual certificategeneration steps to install to System keychain instead of login
keychain.
Mention that code signing certificate generation is automated by the
install script before listing the manual steps to generate a new
code signing certificate.