Fix signedness issue in the DWARF line parser on ARM64 #17031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that it worked, it was the signedness issue |
HoundThe
changed the title
|
scary that a char can be unsigned somewhere :S good finding! |
|
Maybe use the usual int instead of |
|
Sure, why not |
trufae
reviewed
Jun 10, 2020
XVilka
approved these changes
Jun 11, 2020
trufae
approved these changes
Jun 11, 2020
trufae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
(tests are already there)
I am abusing PR so I can run tests on ARM to check if I found the error for #15688
I think it might be because signedness of
charis implementation defined and the line_base is supposed to be -5, but instead it's 251 which is -5 on 8bit 2's complement