Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring merge sort and insertion sort cmp function semantics together #17473

Merged
merged 6 commits into from Sep 9, 2020
Merged

Bring merge sort and insertion sort cmp function semantics together #17473

merged 6 commits into from Sep 9, 2020

Commits on Aug 28, 2020

  1. Trace debugger test: fix for distro with different glibc 

    This fixes the trace debugger test by removing the content of rdx, which
changes on Fedora glibc, or recent Ubuntu with glibc AVX2 support.

Ideally this test should be modified to depend less on the system libc.
    @anisse
    anisse committed Aug 28, 2020
    Copy the full SHA
    c3d93d4 View commit details
    Browse the repository at this point in the history

  2. Double regs: add fake support for 256 bits registers

    @anisse
    anisse committed Aug 28, 2020
    Copy the full SHA
    c935dcd View commit details
    Browse the repository at this point in the history

  3. Update SDB with merge sort and meson fixes

    @anisse
    anisse committed Aug 28, 2020
    Copy the full SHA
    b92b2b9 View commit details
    Browse the repository at this point in the history

  4. RListComparator: fix sort comparators that return bool to return -1, … 

    …0 or 1 ##anal
    @anisse
    anisse committed Aug 28, 2020
    Copy the full SHA
    977364d View commit details
    Browse the repository at this point in the history

  5. Bring merge sort and insertion sort cmp function semantics together #… 

    …#anal

Merge sort uses cmp (a, b) < 0 for its first test branch, and insertion
sort cmp (a, b) > 0 ; which means the 0 boundary goes in one case in one
branch, and in the other sort function in the other branch.

It makes it possible to support compare function that return true/false
instead of -1/0/1; although this isn't an acceptable use of
RListComparator, this prevents future bugs from appearing, because this
works with insertion sort, but not merge sort.

The main advantage of this patch is that both sort functions should sort
equal elements the same way. This stability is important for zignatures
for example.
    @anisse
    anisse committed Aug 28, 2020
    Copy the full SHA
    6be5f99 View commit details
    Browse the repository at this point in the history

  6. Fix tests that were impacted by wrong register ordering ##anal

    @anisse
    anisse committed Aug 28, 2020
    Copy the full SHA
    53e9320 View commit details
    Browse the repository at this point in the history