New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fortunes: remove nsfw and creepy fortunes #17980
Conversation
These fortunes make a lot of people unconfortable and can be trigering for some. Even if they are not active by default, they should have no place here if you are trying to be a welcoming project. There are a lot of other ways to be quirky and fun, I see no logical reason to have these fortunes knowing they will negatively impact people. Signed-off-by: Filipe Laíns <lains@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see how nsfw fortunes may be considered offensive to some, but there is no reason to remove the creepy ones. There are way more creepy things inside this repo.
Some of them are still uncomfortable and may be triggering. Those are the obvious ones.
That would be very much an issue. |
I am triggered by dynamically typed languages. That is not an argument.
PR to rewrite the swift demangler is welcome. -- |
Codecov Report
@@ Coverage Diff @@
## master #17980 +/- ##
==========================================
- Coverage 40.40% 40.39% -0.01%
==========================================
Files 1137 1137
Lines 359287 359287
==========================================
- Hits 145159 145145 -14
- Misses 214128 214142 +14
Continue to review full report at Codecov.
|
Yeah, that is absolutely the same 😞 I will not waste my time trying to explain how these sentences are bad and this project would be better without them. @trufae this is what people are referring to when they criticize radare2. People are not out to get you, and do not hate radare2 just because... They are referring to this kind of behavior, which is harmful to others. I don't understand how having these stupid sentences show up when you start the program is worth possibly hurting users. |
I am reopening this in the hopes you reconsider. I have looked at the community guidelines for Open Collective and I believe neither of the fortune categories meets them. https://docs.opencollective.com/help/about/community-guidelines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the community believes it's so harmful - let's merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a good reason.
Could you please point out the specific sentences that it violates? I think then there is a concrete argument for removal. |
Hello @thestr4ng3r, From https://docs.opencollective.com/help/about/community-guidelines#be-respectful:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I agree that this can be considered to apply here.
Absolutely incredible that you can link a document as though it proves your point and then have quite literally a third of that document re-quoted back to you and suddenly agree that it's being violated. Have you even read your own code of conduct before this? Christ, how could you ever possibly even make an argument that this shit has any place here? Like, if it's legacy from people who no longer work on the project or bygone days, then that's unfortunate but whatever, at least it's gone now, but why would you ever put up a fight over a PR which literally does all the work of removing it from your codebase? Glad it's gone but incredulous that we had someone actually arguing to keep it, lol |
First of all, I would kindly ask you to refrain from using curse words here. There is no "own code of conduct" of radare2. The linked document is the one from OpenCollective, but which of course the project also has to follow to the point where it makes sense. As with every other pull request on, there needs to be a proper reasoning of why the change is good and it must be clearly visible to anybody looking at the description or comments. The argument that it MAY be triggering is purely subjective, but the quoted paragraph covers it concrete enough. Without this, I may for example also say that I, as an atheist, am triggered by your comment because you used the word "Christ". |
It's painfully obvious that you've never been actually triggered by anything in your life and are evidently incapable of being empathetic enough towards other people to realize that you seeing the word Christ is on such a different level from an actual trigger that it's not even on the same plane of existence. |
I completely agree. And this is exactly the point why proper reasoning is strictly necessary for these kinds of topics. |
Your checklist for this pull request
Detailed description
From the commit description: