Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fortunes: remove nsfw and creepy fortunes #17980

Merged
merged 1 commit into from Nov 29, 2020

Conversation

FFY00
Copy link
Contributor

@FFY00 FFY00 commented Nov 27, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description

From the commit description:

These fortunes make a lot of people unconfortable and can be trigering
for some. Even if they are not active by default, they should have no
place here if you are trying to be a welcoming project.

There are a lot of other ways to be quirky and fun, I see no logical
reason to have these fortunes knowing they will negatively impact
people.

These fortunes make a lot of people unconfortable and can be trigering
for some. Even if they are not active by default, they should have no
place here if you are trying to be a welcoming project.

There are a lot of other ways to be quirky and fun, I see no logical
reason to have these fortunes knowing they will negatively impact
people.

Signed-off-by: Filipe Laíns <lains@riseup.net>
Copy link
Contributor

@thestr4ng3r thestr4ng3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see how nsfw fortunes may be considered offensive to some, but there is no reason to remove the creepy ones. There are way more creepy things inside this repo.

@FFY00
Copy link
Contributor Author

FFY00 commented Nov 27, 2020

Your hair smells different when you are not sleeping.

My sister says that mommy killed her. Mommy says that I don't have a sister.

I wanted you to fill what I felt.

Nobody can hear your calls for help

Some of them are still uncomfortable and may be triggering. Those are the obvious ones.

There are way more creepy things inside this repo.

That would be very much an issue.

@thestr4ng3r
Copy link
Contributor

thestr4ng3r commented Nov 27, 2020

Your hair smells different when you are not sleeping.

My sister says that mommy killed her. Mommy says that I don't have a sister.

I wanted you to fill what I felt.

Nobody can hear your calls for help

Some of them are still uncomfortable and may be triggering. Those are the obvious ones.

I am triggered by dynamically typed languages. That is not an argument.

There are way more creepy things inside this repo.

That would be very much an issue.

PR to rewrite the swift demangler is welcome.

--
EDIT: I would like to distance myself from this and some of the following comments, I failed to phrase my words correctly and they came out rude and disrespectful. In the end, I do believe that removing these fortunes was a wise move which I support.

@codecov-io
Copy link

Codecov Report

Merging #17980 (a1e521f) into master (a335247) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17980      +/-   ##
==========================================
- Coverage   40.40%   40.39%   -0.01%     
==========================================
  Files        1137     1137              
  Lines      359287   359287              
==========================================
- Hits       145159   145145      -14     
- Misses     214128   214142      +14     
Impacted Files Coverage Δ
libr/core/fortune.c 0.00% <ø> (ø)
libr/core/cconfig.c 88.91% <100.00%> (ø)
libr/debug/p/native/procfs.c 78.94% <0.00%> (-10.53%) ⬇️
libr/debug/pid.c 28.57% <0.00%> (-10.21%) ⬇️
libr/util/sys.c 51.16% <0.00%> (-0.24%) ⬇️
libr/debug/p/native/linux/linux_debug.c 49.22% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a335247...a1e521f. Read the comment docs.

@FFY00
Copy link
Contributor Author

FFY00 commented Nov 27, 2020

I am triggered by dynamically typed languages. That is not an argument.

Yeah, that is absolutely the same 😞

I will not waste my time trying to explain how these sentences are bad and this project would be better without them.

@trufae this is what people are referring to when they criticize radare2. People are not out to get you, and do not hate radare2 just because... They are referring to this kind of behavior, which is harmful to others.

I don't understand how having these stupid sentences show up when you start the program is worth possibly hurting users.

@FFY00 FFY00 closed this Nov 27, 2020
@FFY00
Copy link
Contributor Author

FFY00 commented Nov 28, 2020

I am reopening this in the hopes you reconsider. I have looked at the community guidelines for Open Collective and I believe neither of the fortune categories meets them.

https://docs.opencollective.com/help/about/community-guidelines

@FFY00 FFY00 reopened this Nov 28, 2020
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the community believes it's so harmful - let's merge it.

Copy link
Contributor

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a good reason.

@thestr4ng3r
Copy link
Contributor

I am reopening this in the hopes you reconsider. I have looked at the community guidelines for Open Collective and I believe neither of the fortune categories meets them.

https://docs.opencollective.com/help/about/community-guidelines

Could you please point out the specific sentences that it violates? I think then there is a concrete argument for removal.

@stephen-fox
Copy link

Hello @thestr4ng3r,

From https://docs.opencollective.com/help/about/community-guidelines#be-respectful:

We have zero tolerance for unacceptable behavior. Being a jerk will
not get you a place in this community; it will turn people away.
We don’t want that noise in the system. If your account is found
to be engaged in any kind of unacceptable behavior, we can close it.

Unacceptable behaviors include: spamming, trolling, intimidating,
harassing, abusive, discriminatory, derogatory or demeaning speech
or actions by any participant in our community online, at all related
events and in one-on-one communications carried out in the context
of community business. 

Harassment includes: harmful or prejudicial verbal or written comments
related to gender, sexual orientation, race, religion, disability;
inappropriate use of nudity and/or sexual images (including
presentation slides); inappropriate depictions of violence (including
presentation slides); deliberate intimidation, stalking or following;
harassing photography or recording; sustained disruption of talks
or other events; inappropriate physical contact, and unwelcome
sexual attention.

Copy link
Contributor

@thestr4ng3r thestr4ng3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I agree that this can be considered to apply here.

@trufae trufae merged commit 163312b into radareorg:master Nov 29, 2020
@fu5ha
Copy link

fu5ha commented Nov 29, 2020

Thanks, I agree that this can be considered to apply here.

Absolutely incredible that you can link a document as though it proves your point and then have quite literally a third of that document re-quoted back to you and suddenly agree that it's being violated. Have you even read your own code of conduct before this? Christ, how could you ever possibly even make an argument that this shit has any place here? Like, if it's legacy from people who no longer work on the project or bygone days, then that's unfortunate but whatever, at least it's gone now, but why would you ever put up a fight over a PR which literally does all the work of removing it from your codebase?

Glad it's gone but incredulous that we had someone actually arguing to keep it, lol

@thestr4ng3r
Copy link
Contributor

First of all, I would kindly ask you to refrain from using curse words here.

There is no "own code of conduct" of radare2. The linked document is the one from OpenCollective, but which of course the project also has to follow to the point where it makes sense.

As with every other pull request on, there needs to be a proper reasoning of why the change is good and it must be clearly visible to anybody looking at the description or comments. The argument that it MAY be triggering is purely subjective, but the quoted paragraph covers it concrete enough. Without this, I may for example also say that I, as an atheist, am triggered by your comment because you used the word "Christ".

@fu5ha
Copy link

fu5ha commented Nov 29, 2020

It's painfully obvious that you've never been actually triggered by anything in your life and are evidently incapable of being empathetic enough towards other people to realize that you seeing the word Christ is on such a different level from an actual trigger that it's not even on the same plane of existence.

@thestr4ng3r
Copy link
Contributor

I completely agree. And this is exactly the point why proper reasoning is strictly necessary for these kinds of topics.

@radareorg radareorg locked as too heated and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants