Fix memleak in db/esil/apple #18238
Merged
Fix memleak in db/esil/apple #18238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we can merge this PR as is? or you want to address this skiplist issue you mention in te same pr? |
You mean add the api to automatically free? If you think it’s the right way, then i’ll do it in this pr. |
trufae
requested changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
#18150
As I said in discord, there's a problem of
r_skiplist_insert. When it meets duplicate key, it simply returns the original node. but this result is always ignored, thus a callr_skiplist_insert (list, data)may cause memory leak.Should we check the result every time, or use a new function to insert and free if duplicate?
the leak can be reproduced by
r2 -Qc 'pd 2~?push' bins/mach0/arm16-ofp.lzh