Support writing PE32/PE32+ section permissions #7058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on adding support for writing PE32(+) section permissions (see #921).
The patch works fine so far (it's mostly adapted from the ELF code), but I've seen that sections that do not have a name get one auto-assigned.
bins/pe/normal64.exe
is an example of this:Here
sect_0
was autogenerated and is not actually in the file. This is a problem when trying to modify the section permissions, as the code checks the raw names from the binary and not the ones radare "sees". So to change the permissions one would have to invoke rabin2 like this:rabin2 -O p//x normal64.exe
(i.e. with empty section name). It works, but it's not pretty and also fails when there are multiple unnamed sections. How could this be handled better? I can't use the parsed section info for looking up the name since that can't be mapped back to the right section in the binary (sections might get dropped during parsing under certain circumstances so the indices could differ).