-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua 5.3 Assembler/Disassembler, Analyzer and Binary Plugin (#3836) #7197
Conversation
grouped global data together
Please, use r2-indent or follow the indentation rules.
Not sure if we should have this in r2 core or extras, seems like an interesting addition to me and pretty well implemented. We shoul add some tests and fuzz it a bit beforee the release
… On 1 Apr 2017, at 13:32, Cararasu ***@***.***> wrote:
Implementation of an assembler and disassembler of the Lua 5.3 VM bytecode
Implementation of a binary plugin, that can analyze the binary format of a Lua 5.3 compiler
Implementation of an analyzer plugin for Lua 5.3 VM bytecode
You can view, comment on, or merge this pull request online at:
#7197
Commit Summary
Added Lua 5.3 Assembly and Disassembly
Implemented Lua 5.3 Binary Analyzer #3836
removed unnecesasry prints for lua implementation #3836
implemented caching for parsing the lua-file #3836
added mnemonics to analyzer and fixed a wrong instructionname
replaced llx and llu with PFMT64x
removed trailing whitespaces from lua 5.3 assembler and binary analyzer
made all functions in lua53 plugins that are possible static
merged lua53 plugins with main branch
File Changes
A libr/anal/arch/lua53/lua53_parser.c (392)
M libr/anal/p/Makefile (2)
A libr/anal/p/anal_lua53.c (223)
A libr/anal/p/lua53.mk (12)
A libr/asm/arch/lua53/lua53.c (415)
A libr/asm/arch/lua53/lua53.h (230)
A libr/asm/d/lua53 (47)
M libr/asm/p/Makefile (2)
A libr/asm/p/asm_lua53.c (35)
A libr/asm/p/lua53.mk (11)
M libr/bin/p/Makefile (2)
A libr/bin/p/bin_lua53.c (329)
A libr/bin/p/lua53.mk (12)
M libr/include/r_anal.h (1)
M libr/include/r_asm.h (1)
M libr/include/r_bin.h (3)
M plugins.def.cfg (3)
Patch Links:
https://github.com/radare/radare2/pull/7197.patch
https://github.com/radare/radare2/pull/7197.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
No problem with the license. Mit is comptible with lgpl. But im trying not to make core bigger and slowly move things to extras, to reduce codebase, compilation times and tests for core. But anyway i guess that we should do some kind of poll to see how many prople want things in core or not.
But adding lua dis/asm/anal have been in my list for long time so its ok to go into core for me.
… On 2 Apr 2017, at 00:10, Maijin ***@***.***> wrote:
@radare
+ .license = "MIT", ->another reason for r2extras
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
meh, tired of waiting |
thanks for the contrib! very nice addition, i'll try to find some time to fix the indentation hints and prepare a good path to move things into extras in future releases after some polls :) |
Great! |
e anal.noncode
… On 03 Apr 2017, at 12:04, Cararasu ***@***.***> wrote:
Great!
Btw. is there a way to set the address of a function to a non executable section or have the base address of a function be a different one than the actual address of the code, because in lua there is much function-related data before the actual code-section of each function?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#7197 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3-lsJc8a-nhJFMdyCcczfUs1BMSUxiks5rsMRDgaJpZM4Mwdd5>.
|
Implementation of an assembler and disassembler of the Lua 5.3 VM bytecode
Implementation of a binary plugin, that can analyze the binary format of a Lua 5.3 compiler
Implementation of an analyzer plugin for Lua 5.3 VM bytecode