Better handling of location permissions #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KennyHuRadar
changed the title
lmeier
reviewed
May 30, 2024
| @@ -53,20 +53,26 @@ class MyRadarReceiver : RadarReceiver() { | |||
|
|
|||
| override fun onLocationUpdated(context: Context, location: Location, user: RadarUser) { | |||
| val body = "${if (user.stopped) "Stopped at" else "Moved to"} location (${location.latitude}, ${location.longitude}) with accuracy ${location.accuracy}" | |||
| notify(context, body) | |||
| // notify(context, body) | |||
There was a problem hiding this comment.
Commenting out stuff in the example app as I'm clobbering it for the sake of building the android demo. I plan to revert all changes made to the example app before merging.
Comment on lines
+70
to
+71
| implementation "androidx.activity:activity:1.2.0" | ||
| implementation "androidx.fragment:fragment:1.3.0" |
There was a problem hiding this comment.
note: check which version of android is required for these
There was a problem hiding this comment.
@KennyHuRadar mind doing that really quick?
lmeier
reviewed
May 31, 2024
| context: Context, | ||
| status: RadarLocationPermissionStatus | ||
| ) { | ||
| onPermissionsUpdated(context, status) |
| } | ||
|
|
||
| /** | ||
| * @return A RadarPermissionsStatus object with the current location permissions status. |
| internal fun sendLocationPermissionStatus(status: RadarLocationPermissionStatus) { | ||
| receiver?.onLocationPermissionStatusUpdated(context, status) | ||
|
|
||
| logger.i("📍️ Radar location permissions updated | status = $status") |
…ithout-changes-to-sdk
KennyHuRadar
deleted the
kenny-hu/fence-1912-modified-example-app-without-changes-to-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have clobbered the example app to make a demo utilizing the new location permissions manager. We will revert that change.