Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coalescing trackOnce calls to initialize, resume, and location auth listener #318

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add coalescing trackOnce calls to initialize, resume, and location auth listener #318

wants to merge 12 commits into from

Conversation

york-wei
Copy link
Contributor

No description provided.

@york-wei
Copy link
Contributor Author

york-wei commented Mar 19, 2024 •
edited

Waypoint testing:

  • on app start, Waypoint triggers two trackOnce calls while the SDK triggers two trackOnce calls via auth listener and initialize. Three calls are coalesced and last trackOnce call by Waypoint fires a second after (due to semaphore when sleep=YES)
Screenshot 2024-03-19 at 5 00 00 PM - on app resume, Waypoint triggers a `trackOnce` call and the SDK triggers a `trackOnce` call via resume callback. The two calls are coalesced together Screenshot 2024-03-19 at 5 03 26 PM

"reached track completion" is only logged when a track api call has been made

@york-wei york-wei marked this pull request as ready for review March 19, 2024 21:04
ShiCheng-Lu pushed a commit that referenced this pull request Jun 13, 2024
@KennyHuRadar
Fix for set foreground service options icon (#318)
0231cec 
* Change notification icon from an integer to a string in RadarForegroundService and RadarTrackingOptions

* Change notification icon type from integer to string in RadarForegroundService and RadarLocationManager

* fix for test

* bump version and also add toJson field

* added back icon as default

* change val to var

* make calls with unexplicit parameter naming non-breaking

* cahnge back icon int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmeier lmeier Awaiting requested review from lmeier

@KennyHuRadar KennyHuRadar Awaiting requested review from KennyHuRadar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@york-wei