Add a Radar.clearTripOptions interface #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #10965: Add a Radar.clearTripOptions interface to radar-sdk-js. |
jkao
deleted the
radarjeff/sc-10965/add-a-radar-cleartripoptions-interface-to
branch
corypisano
approved these changes
Jul 14, 2022
jrtibbetts
reviewed
Jul 14, 2022
Comment on lines
205
to
209
| if (!tripOptions) { | ||
| Radar.clearTripOptions(); | ||
| return; | ||
| } | ||
| Storage.setItem(Storage.TRIP_OPTIONS, JSON.stringify(tripOptions)); |
There was a problem hiding this comment.
Would
if (!tripOptions) {
Storage.setItem(Storage.TRIP_OPTIONS, JSON.stringify(tripOptions));
}
have the same effect, or does explicitly calling Storage.removeItem() have some side effects that need to happen?
There was a problem hiding this comment.
we'd need to guard against JSON.stringify(null/undefined) in any case.
at the moment, this interface doesn't have a lot of guard rails, so a future iteration could do more type-checking against what tripOptions are and be more precise. this seems reasonable for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.