Integrate h264 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekg
commented
Jan 13, 2023
| @@ -193,6 +193,15 @@ func (svc *WebRTCService) CreatePlaybackConnection(client *PeerClient) error { | |||
| svc.recordingsLock.Lock() | |||
| defer svc.recordingsLock.Unlock() | |||
|
|
|||
| // Allow us to receive 1 audio track, and 1 video track | |||
| if _, err = client.pc.AddTransceiverFromKind(webrtc.RTPCodecTypeAudio); err != nil { | |||
There was a problem hiding this comment.
This doesn't do anything useful...
radekg
commented
Jan 13, 2023
| @@ -204,7 +213,7 @@ func (svc *WebRTCService) CreatePlaybackConnection(client *PeerClient) error { | |||
| svc.logger.Info("I have an AV data", "data-id", id, "video-length", avr.video.Len()) | |||
|
|
|||
| // Create a video track | |||
| videoTrack, videoTrackErr := webrtc.NewTrackLocalStaticSample(webrtc.RTPCodecCapability{MimeType: webrtc.MimeTypeVP8}, "video", "pion") | |||
| videoTrack, videoTrackErr := webrtc.NewTrackLocalStaticSample(webrtc.RTPCodecCapability{MimeType: webrtc.MimeTypeH264}, "video", "pion") | |||
There was a problem hiding this comment.
Of course, one needs the correct mime type for H264 video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a pointless exercise because the h264 data (codec?) does not appear to be working. Per documentation in the code. Anyway, I've added media format selection when reading from storage. First step towards abstracting storage from the main recording app.