Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift5 & Xcode 10.2 #48

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Swift5 & Xcode 10.2 #48

wants to merge 9 commits into from

Conversation

radianttap
Copy link

Code works on its own, just config stuff

Aleksandar Vacic and others added 4 commits March 27, 2019 13:28
Updated watchOS deployment target to 3.0 because that’s now minimum for AppStoreConnect.
Bumped version.
@Halenda
Copy link

Halenda commented Jul 8, 2019

I think Travis-CI should be reconfigured to exit without errors, but code looks fine. @radex, can you review this MR?

@antoinelamy
Copy link

@radianttap could you edit the .travis.yml in your PR so it can be merged?

@radianttap
Copy link
Author

I never used Travis thus I have no idea what to edit. I believe owners can edit the PR..?

@antoinelamy
Copy link

@radianttap unfortunately I'm not an owner so I cannot edit the file myself. Basically, you just have to update the value for osx_image in this file:

https://github.com/radex/SwiftyTimer/blob/master/.travis.yml

osx_image: xcode11.2 should do the job.

@radianttap
Copy link
Author

Ok, done.

@antoinelamy
Copy link

Looks like line 20 must be changed as well to update the target operating system:
- xcodebuild -project "$PROJECT" -scheme 'SwiftyTimer' -destination 'name=iPhone 8,OS=12.4' ONLY_ACTIVE_ARCH=NO CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO build | xcpretty

@radianttap
Copy link
Author

Chasing Travis tail, done.

@antoinelamy
Copy link

Thanks! @radex can you review?

@radex
Copy link
Owner

radex commented Dec 4, 2019

@antoinelamy Sorry, I don't maintain this project anymore — @asowers1 does.

s.license = 'MIT'
s.summary = 'Swifty API for NSTimer'
s.homepage = 'https://github.com/radex/SwiftyTimer'
s.authors = { 'Radek Pietruszewski' => 'this.is@radex.io' }
s.source = { git: 'https://github.com/radex/SwiftyTimer.git', tag: s.version }
s.swift_version = '4.2'

s.swift_version = '5.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should not be required as swift_versions is defined later on and overwrites it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the time when I added that, swift_versions was new so newer CocoaPods was using it while older ones ignored it. I agree, this can now be updated to just one setting, I believe everyone has moved on.

@antoinelamy
Copy link

@asowers1 review please?

@NSExceptional
Copy link

@asowers1 @radex please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants