Skip to content

Commit

Permalink
Fix type errors
Browse files Browse the repository at this point in the history
  • Loading branch information
radiac committed Jan 5, 2020
1 parent 7a84c4a commit 80091a1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
13 changes: 7 additions & 6 deletions fastview/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,19 @@
Form classes
"""

from typing import List, Optional
from typing import List

from django.forms import ModelForm, BaseInlineFormSet
from django.forms import BaseInlineFormSet, ModelForm


class InlineParentModelForm(ModelForm):
formsets: Optional[List[BaseInlineFormSet]]
formsets: List[BaseInlineFormSet]

def add_formset(self, formset: BaseInlineFormSet):
if not hasattr(self, "formsets"):
self.formsets = []
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self.formsets = []

def add_formset(self, formset: BaseInlineFormSet):
self.formsets.append(formset)

def is_valid(self):
Expand Down
2 changes: 1 addition & 1 deletion fastview/views/inlines.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from typing import Any, Dict, Optional, Type

from django.db.models import Model
from django.forms import ModelForm, BaseInlineFormSet
from django.forms import BaseInlineFormSet, ModelForm
from django.forms.models import inlineformset_factory

from ..forms import InlineParentModelForm
Expand Down
5 changes: 2 additions & 3 deletions fastview/views/mixins.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,13 @@
from django.urls import reverse

from ..constants import INDEX_VIEW
from ..permissions import Denied, Permission
from ..forms import InlineParentModelForm
from ..permissions import Denied, Permission
from .display import AttributeValue, DisplayValue
from .objects import AnnotatedObject


if TYPE_CHECKING:
from django.forms import BaseInlineFormSet

from ..viewgroup import ViewGroup
from .inlines import Inline

Expand Down Expand Up @@ -243,6 +241,7 @@ class InlineMixin:

# TODO: Consider merging with FormFieldMixin when adding support for nested inlines
model: Model # Help type hinting to identify the intended base classes
get_form_kwargs: Callable # Help type hinting
inlines: Optional[List[Inline]] = None

def get_form(self, form_class=None):
Expand Down

0 comments on commit 80091a1

Please sign in to comment.