New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 compatibility, fulltext tag search and document update #102
Conversation
@radiac I like the concise tag tree implementation in tagulous and have used it in my python3 + django3 project. While working on my project I have added these changes to make it work. Thanks for making it available to the community. |
calling weight() would result in "division by 0" error as everything is zero
@radiac whenever you're available, could you please check the code and merge them to your current branch? thanks. |
Hi, @radiac how can I contribute my code to your project? Thanks! |
I was looking for a similar features but I simply used a customized autocomplete_view function. Perhaps this is why @radiac did not want to add this as one of the core features? |
I have a PR pending for more flexible view function. It is much simpler than your solution but might still not be merged. I am using a fork for my project anyway. |
Sorry for the delay - I haven't closed the pr, it looks interesting, but unfortunately it came in while I was finishing up the refactor to remove py2, so it wasn't a simple one to merge - I'll need to cherry pick bits. The past few months have been very busy, but I hope to get to it soon. |
When there are tags but all have a zero count, the max count should be 1 to avoid unexpected results after division by zero
Thanks for the PR, finally had a chance to pick out the compatible changes and add some tests. Closing, merged via #128. |
Changes made
autocomplete_fulltext
to make full text search on autocompletion, default is offautocomplete_fulltext
they may break tagulous on python2, never tested.