Fixed DoesNotExist exeption in case of different databases for read and write #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and write - Changed db_for_write parameters
17 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have find an issue with django-tagulous in case of multiple database configuration.
Here is my database configuration:
DATABASES = {
'default': { # Master DB for read and write
"ENGINE": "django.contrib.gis.db.backends.postgis",
"USER": "some_user",
"NAME": "some_db",
"PASSWORD": "",
"HOST": "host",
"PORT": "5432"
},
'reader': { # Readonly Slave DB
"ENGINE": "django.contrib.gis.db.backends.postgis",
"USER": "some_user",
"NAME": "some_db",
"PASSWORD": "",
"HOST": "host",
"PORT": "5432"
},
}
With this configuration i got en exeption: Tagulous__ matching query does not exist.
I think this is because Django admin tries to cover all queries into single transaction so until it will be closed the slave DB will not be updated with new data.
So when we just updated the tag counter we should use the same DB to refresh tag instance.