Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just opened issue #81, because I cannot use single character tags with the current version
of tagulous. Here is a pull request which might fix the issue.
First I've added some tests to show the problems I have. Second, I've replaced the function
utils.split_tree_name(name)
with simpler code.Do I miss something or can it just be implemented by using the
split()
method of strings, as I did?One drawback of my solution is that you cannot use a NULL character in tags anymore,
but that shouldn't be problem - although there also would be a solution for that.
What do you think? The tests are passing, also the new ones I've added.