strip NUL characters where it actually matters #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcrypt doesn't handle NUL characters. Probably with that in mind, mara strips any NUL char from the string that is going to be hashed. However, the strip is taking place before sha512'ing the password, and sha512 *can* produce NUL chars. This patch moves the stripping of NUL characters to the already sha512 hashed string, thus ensuring that no NUL character reaches the bcrypt hashing function itself. Note: since this actually changes the hashed password, this change might not be backwards compatible with your current database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bcrypt doesn't handle NUL characters. Probably with that in mind,
mara strips any NUL char from the string that is going to be hashed.
However, the strip is taking place before sha512'ing the password,
and sha512 can produce NUL chars.
This patch moves the stripping of NUL characters to the already sha512
hashed string, thus ensuring that no NUL character reaches the bcrypt
hashing function itself.
Note: since this actually changes the hashed password, this change
might not be backwards compatible with your current database.