Add python3.7 support #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just need to announce the support, as there are no code changes needed in order to make it work.
The previous commit was incomplete.
Travis builds aren't doing what they were supposed to: while there's a a test with a TOXENV for each of the python versions, they are being actually tested with Python 3.6. For eg.: https://travis-ci.org/radiac/mara/builds/437932931 has four tests: 38.1 Python: 3.6 TOXENV=py27 44 sec 38.2 Python: 3.6 TOXENV=py34 44 sec 38.3 Python: 3.6 TOXENV=py36 44 sec 38.4 Python: 3.5 TOXENV=py35 52 sec This patch is meant to fix that.
Due to python 2.7's EOL, pip in the test environment will fail, with the message: DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
revert line removal that was there by mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch also happens to actually fix the current travis configuration.