Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] More formatters #24

Merged
merged 7 commits into from
Aug 8, 2021

Conversation

PrimaryCanary
Copy link
Contributor

@PrimaryCanary PrimaryCanary commented Jan 16, 2021

I'll be adding many more formatters in the next few days. I hope to reach parity with emacs-format-all-the-code. Each one will be a separate commit for easy cherry-picking.

I've read your contributor guide. I'll update the changelog and such when I'm closer to finishing this pull.

Sifus added 5 commits January 16, 2021 00:31
There's a lot of LaTeX modes. I'm not sure how to distinguish them.
Alphabetizing them makes it easier to find which formatters are
supported.
@raxod502
Copy link
Member

Wow, this is phenomenal. Thanks!

@raxod502 raxod502 marked this pull request as ready for review August 8, 2021 13:03
@raxod502 raxod502 merged commit 8e022c6 into radian-software:master Aug 8, 2021
@raxod502
Copy link
Member

raxod502 commented Aug 8, 2021

I hope you don't mind---I've updated the changelog, merged in master, and included this for the next release. We can always add even more formatters in the future!

@adimit
Copy link
Contributor

adimit commented Aug 8, 2021

Hi, that's somewhat bad timing right now, because I've just been writing an issue about integrating rustfmt. I'm afraid the proposed PR will not work for rustfmt. I'll post the issue in a moment.

@adimit adimit mentioned this pull request Aug 8, 2021
raxod502 added a commit that referenced this pull request Jan 5, 2022
Closes #24
Builds on #25 by @PrimaryCanary

Creating a pull request for this so that I can test the functionality
for installing and running only the formatters that are changed in a
given pull request.
@raxod502 raxod502 mentioned this pull request Jan 5, 2022
raxod502 added a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants