Initialize selectrum after all other functions in minibuffer-setup-hook

[clemera]

When using completing-read sorting can be configured/disabled by providing display-sort-function via the metadata. To correctly disable sorting for selectrum-read one needs to set it in minibuffer-setup-hook like this:

(minibuffer-with-setup-hook
    (lambda ()
      (setq-local selectrum-should-sort-p nil))
  (selectrum-read "Switch to: " 
                  '("longest" "longer" "short")))

Before this PR this doesn't actually work because selectrum--minibuffer-setup-hook runs before the temporary hook added above. Alternatively we could use (:append (lambda ...)) for selectrum-read but this might cause unexpected side effects for existing code which assumes selectrum-read runs early, we also have such code in selectrum itself (see selectrum-read-file-name). Because of that I moved the sorting code into selectrum--minibuffer-post-command-hook which seems like the simplest fix without breaking anything due to changed behaviour.

[minad]

@clemera I wonder if there is a simpler alternative to disable sorting. I think the nicety of using let with selectrum-should-sort-p is somehow lost using this hook idiom. Rather add a :sort option to the selectrum api? I always have recursive minibuffers enabled and use them often. Therefore I would always prefer to disable things locally. Always writing this minibuffer hook idiom is very ugly.

[clemera]

Yeah, it's not too beautiful ;) Generally we don't want to encourage using selectrum-read and adding more options and convenience features would probably result in more users use it instead of completing-read.

[minad]

@clemera Please look at my proposal in #243. I don't have a really good solution yet, but I need something like configuration "from outside"...

[minad]

Anything preventing from merging this? Looks simple enough.

[clemera]

I'm still thinking if we shouldn't move to use (:append ...) within selectrum-read instead because it would be cleaner and does not need us to move additional code into post command hook if we add more variables which are set initially. We can also refactor that later though if there is need to hurry, I guess you want to get it merged before consult gets included in melpa?

[minad]

@clemera No hurry from me and the melpa pipeline is kind of clogged - just asking.

[clemera]

I assume there isn't any code out there which relies on this minor detail. I adjusted the case where we used (:append...) around selectrum-read accordingly.