Straight Doesn't Add Some of the Dependencies When Building Magit #964
Comments
|
Possibly related: I've experienced straight not getting dependencies of other packages than magit.
|
|
I ran into magit #5011 and in an effort to resolve it I uninstalled magit and all its dependencies and re-installed them. This didn't resolve the issue unfortunately but I noted I'm using |
Correct. The library has been part of Emacs core since version 25 and is also explicitly ignored via |
|
Dangit, I didn't know that Package-Requires was allowed to be multiline. I guess that's a bug in my implementation of reading the dependencies of a package. Let me fix now. |
|
Actually, no - I think this is a bug in Magit. The official Emacs documentation explicitly says of
(emphasis mine) |
|
Never mind a third time, that is true but still not a problem because Magit also includes I will still report the formatting issue to Magit. |
|
I believe I've reported the same issue once before, but I don't recall of it was with magit. While the doc does state a single line, package.el handles multiple lines, IIRC. |
|
Hum, okay, so not only did you already know about the issue, but already fixed it, so everything I said was in fact somewhat irrelevant. That's what I get for being out of the loop so long, sorry! Although I'd still perhaps argue that since the docs say it should be one line, it should be one line. |
Not a problem. If you hadn't mentioned the one-line thing, I wouldn't have remembered.
Agreed, or the doc should be changed to reflect the package.el implementation. |
I take it is not a problem that this file uses different version numbers for some packages wrt to the |
At this time, straight.el does not consider the version number information. So that should not cause any problems. |
…operly [#964] Allow installing seq from GNU ELPA
|
I think this should be resolved on develop |
|
OK, trying to confirm this. I've switched to the |
|
Check the definition of |
|
OK, so I must have done something wrong. For whatever reason when I switched to I removed The only way I could pull it in was to remove all the same packages as described above and restart Emacs. Perhaps unsurprising. I presume this was necessary as the built-in In any case, from my perspective this issue is resolved. |
|
This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and I will be happy to reopen the thread :) |
What's wrong
Straight doesn't use some of the dependencies when building package such as Magit (in this case it doesn't add the Transient dependency) which leads to one of the macro used by Magit to be undefined when byte-compiled.
Test Case
2022-06-21 18:04:08gnu/linuxprerelease (grafted, HEAD -> develop, replaced) 0e204d4 2022-06-16GNU Emacs 28.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6) of 2022-04-28Output
The command above produce the same .elc files as shown below.
Output
Output
Version information
The text was updated successfully, but these errors were encountered: