straight--build-compile: properly set load-path #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous method involved looking up each package's dependencies. It did not account for local-repo names and transitive dependencies. Now we just recursively add straight's build dir to the load-path when byte-compiling. This should cover all cases.
progfolio
force-pushed
the
fix/byte-comp-load-deps
branch
from
af3dcde
to
5ffd493
Compare
|
Hmmm... that seems like it would almost always work, but doesn't it technically make the environment a bit nondeterministic on account of random old things lying around in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous method involved looking up each package's dependencies.
It did not account for local-repo names and transitive dependencies.
Now we just recursively add straight's build dir to the load-path
when byte-compiling. This should cover all cases.