Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

CPU 98% #120

Closed
JowiM opened this issue Apr 5, 2014 · 3 comments
Closed

CPU 98% #120

JowiM opened this issue Apr 5, 2014 · 3 comments
Milestone
v1.1.3

Comments

@JowiM
Copy link

JowiM commented Apr 5, 2014

The only problem I found is that it uses a lot of cpu. When I check in the Activity Monitor it consumes 98%. Other then that its a great application.

Thanks
@bgammill
Copy link

bgammill commented Apr 6, 2014

Could you post some screenshots of your Activity Monitor? Also, what were you doing whenever this occurred?

@kbhomes
Copy link
Member

kbhomes commented Apr 6, 2014

@JowiM: If I'm correct, you're currently using the Dark theme? If so, that has a known performance regression and this problem will be fixed with what I'm working on to fix #90.

kbhomes added a commit that referenced this issue Apr 6, 2014
@kbhomes
Modify dark.css, CustomWebView to use/hold inverted sprite sheet (fixes
fba0972 
#90, #120)

Previously, many things were made to match the dark style by using the
`-webkit-filter: invert(100%)` idiom in CSS, but this had a huge
performance impact since it was used for every thumbs up in every row,
on every player button, and so on.

To get rid of the performance hit, I instead download the sprite sheet
at the beginning of the program and invert the colors in memory. The
CSS is then updated to point to a special URL
(http://radiant-player-mac/sprites-inverted.png) at which point Radiant
Player returns the inverted image and the performance hit is now gone
as the inverted sprite sheet is now handled as a regular image.

In any forthcoming dark themes or derivatives of the built in theme, if
you need an inverted version of a particular sprite, set the
background-image to this special URL.
@kbhomes kbhomes closed this as completed Apr 6, 2014
@JowiM
Copy link
Author

JowiM commented Apr 6, 2014

@kbhomes you are correct I reverted to cocoa its much less. Thank you

@kbhomes kbhomes added this to the v1.1.3 milestone Apr 7, 2014
kbhomes added a commit that referenced this issue Apr 7, 2014
@kbhomes
Merge branch 'master' into pr/105
24caf71 
* master: (24 commits)
  Fix mini player location at edge of screen, multiple screens (fixes #108)
  Use an NSURLProtocol instead of data: URIs (fixes #123)
  Tweak preferences window height
  Fix notifications on Safari 6/OS X 10.8 (fixes #92)
  Fix CSS for Safari 6 and OS X 10.8 (fixes #91)
  Fix mini player to work on OS X 10.8 (fixes #106)
  Modify dark.css, CustomWebView to use/hold inverted sprite sheet (fixes #90, #120)
  Revert event tap creation, fixes QuickLook but breaks Fireworks (fixes #117)
  Remember last size of mini player (fixes #96)
  Revert "Fix timestamp alignment in Last.fm popover"
  Fix timestamp alignment in Last.fm popover
  Update Last.fm API keys
  Add preference to automatically love/unlove a track on Last.fm based on thumbs up rating (fixes #83)
  Add preference for showing the Last.fm button
  Add ability to love/unlove song from Last.fm popover
  Append Last.fm icon instead of replacing other links
  Add Last.fm popover that shows 10 most recent tracks
  Add NSDate+TimeAgo to podfile
  Update Last.fm icon in preferences
  Fix album title color in dark style (fixes #101, thanks @Deanmv)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.3
Development

No branches or pull requests
3 participants
@JowiM @kbhomes @bgammill