This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Add dock menu #53
Merged
Add dock menu #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wouldn't it be better, easier, and more maintainable to simply connect the Controls menu to the Applications dockMenu outlet? That way you'd have the whole list of menu items that can be used, and changes to the menu will appear in the main menu and the dock menu. |
|
Yes. I originally made it programmatic so I could change the 'Play/Pause' menu item but quickly realized we don't accurately know the current state of play/pause in the code. |
|
Updated PR to re-use the main controls menu. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dock menu that looks like this: