Remove broken observer #400
Conversation
|
👍 Last.fm seems to be working again, and I'd not even noticed that notification centre notifications had stopped, but they seem to be visible now. Nice work! What did you use to debug this, out of interest? I spent a while on it, and couldn't trigger any sort of error so was mostly feeling around in the dark. |
|
For debugging, I enabled the WebKit debugger on the webview (so you can right-click and get to the dev tools) by editing |
|
Some useful info there, cheers. I've made a note for the next time the JS starts acting weird. Anyways, here's a LGTM / :+1: from me. All seems good from what I can see. |
|
@radiant-player/radiant-player-mac Could we get some eyes on this PR when you get a chance? Would be good to get this merged in asap |
|
I'm going to go ahead and merge with the LGTM from @chrismou - feel free to leave comments for review later and we can get them sorted. |
|
Removing broken code? 👍 |
|
@jacobwgillespie I love your commit stats on this repo Added Lines: 3 😉 |
|
Great change, I'll be looking into everything in this repo later tonight. On Mon, Nov 9, 2015 at 3:55 PM, Chris Chrisostomou <notifications@github.com
|
This PR removes part of the rating button observers - they appear to be broken with the current code from Google. I've just removed them here as I'm not sure if they're necessary anymore and if so I'm not sure how to reimplement. I will say though that when combined with #389, it appears to restore LastFM scrobbling and growl notifications.