Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Fix query selector for app bar #413

Merged
merged 1 commit into from
Nov 17, 2015
Merged

Fix query selector for app bar #413

merged 1 commit into from
Nov 17, 2015

Conversation

jacobwgillespie
Copy link
Member

Looks like Google updated their elements again.

@radiant-player/radiant-player-mac this should be ready for review.

Fixes #412

@chrismou
Copy link
Member

Dragging is still a bit ropey - seems to lose control of the window if you drag too quick, but tbh I can't remember what it was like before - it may have always been like this.

That said, ctrl+f shortcut works for me again though. And if people were unable to move the window at all, that doesn't seem to be the case anymore, so it's a definite improvement on how it was.

👍

@jacobwgillespie
Copy link
Member Author

Yep - I added a note to #395 about alternative solutions to fix the dragging:

IMO we should look at alternate implementations - two ideas for further research:

  • implement something like -webkit-app-region: drag from Electron
  • implement the app bar in native code

jacobwgillespie added a commit that referenced this pull request Nov 17, 2015
@jacobwgillespie jacobwgillespie merged commit e8af07b into master Nov 17, 2015
@jacobwgillespie jacobwgillespie deleted the fix-window-drag branch November 17, 2015 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants