This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
DarkCyan theme, plus some Spotify theme fixes #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your binary link is broken (only 188 bytes in that zip), however the design looks great! Props to you and @danielstuart14. I'd recommend changing the theme name to
|
|
Oh yeah, good spot. I changed the name at the last minute, I must have missed that. I'll update that in the morning and get it merged And yeah, looks like I missed the -r on my zip command. Woops. :-/ Fixed now |
chrismou
added a commit
that referenced
this pull request
Nov 30, 2015
DarkCyan theme, plus some Spotify theme fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new DarkCyan theme, inspired by the work done by @danielstuart14 in #348 . Unfortunately, it required an almost ground up rewrite, although now it extends the default Dark theme (rather than just including a copy/paste of the original CSS) meaning that future CSS fixes in response to layout changes should only need to be made in one place.
The work put into this also opens the door to another idea I'm playing with - namely, being able to set your own custom colours - although that may not make an appearance for a little while.
If you spot any missed elements, let me know and I'll take a look!
Edit: To make it simpler, I've set up a release on my fork and attached a binary - save you booting up Xcode :-) https://github.com/chrismou/radiant-player-mac/releases/download/v1.5.0-cyan/RadiantPlayer.app.zip