This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Fix for random unloving/loving of tracks on last.fm #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #390
Essentially, the rating observer was being called before the track info was updated, meaning that for every song it was applying the loved status of the previous song. This PR should fix that.
I've logged a separate issue at #425 to look into stopping the multiple unnecessarily api calls at the start of every song.