This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Some dark theme tweaks #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismou
force-pushed
the
dark-theme-hover-fix
branch
from
7d45594
to
7d957d4
Compare
…play/rating buttons; colour matched scrollbars
chrismou
force-pushed
the
dark-theme-hover-fix
branch
from
7d957d4
to
3f425be
Compare
|
LGTM |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced overuse of background overrides; add cursor:pointer to hover play/rating buttons. Addresses #430
Played some css whack-a-mole, where one fix would break something else, sending me round in circles. In the end - from what I can tell - it looks like we were being a bit too overzealous in our use of background-color:transparent!important;. I'm using the dark theme myself, so I've left the removed rules commented out for reference, so if I spot something broken in the next few days I'll know the first place to check.
To test, just click around and make sure none of the hover effects (ie, when you hover over a song row and the play/rating buttons appear) show up with white backgrounds.
In some rare cases, the buttons don't show up at all. If you see this, try right clicking and reload - I have no idea why (yet) but this seems to fix it and looks to be unrelated to this PR.
Also added a cursor change for the play/ratings buttons to bring inline with the web player.