Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Build website with Jekyll #435

Merged
merged 1 commit into from
Dec 16, 2015
Merged

Build website with Jekyll #435

merged 1 commit into from
Dec 16, 2015

Conversation

jacobwgillespie
Copy link
Member

This depends on #433 getting merged first.

  • Removes unused image, JS, and CSS assets
  • Replaces Slick (the image carousel) with an updated version on a CDN (mainly for https support)
  • Optimizes image assets to reduce bandwidth
  • Adds Jekyll with templated release notes, homepage, and appcast (for app updates)
  • Integrates with automated Travis builds

@jacobwgillespie
Copy link
Member Author

@radiant-player/radiant-player-mac this is ready for review

@jacobwgillespie
Copy link
Member Author

If you'd like to test this, try running ./scripts/build-website.sh then cd website/_site and check out the results.

@chrismou
Copy link
Member

Just a thought - as this is triggered by Travis, does this mean it'll automatically deploy after any commit to master?

@jacobwgillespie
Copy link
Member Author

Yes, that is correct and is by design. For the website, any commit to master will sync gh-pages with the website. It is limited to the master branch, so other branches won't go to gh-pages. I think this is the behavior we want for the website.

For automatically building the app itself, that will have some different logic (based on tags, so that when we tag 1.2.3 it will build and deploy 1.2.3, but only on that specific commit).

@chrismou
Copy link
Member

Seems to be a merge conflict in index.html. Let me know when that's sorted and I'll check it out.

And don't forget to port over the PR from last night as I think it's included in the "old" section ;-)

* Removes unused image, JS, and CSS assets
* Replaces Slick (the image carousel) with an updated version on a CDN (mainly for https support)
* Optimizes image assets to reduce bandwidth
* Adds Jekyll with templated release notes, homepage, and appcast (for app updates)
* Integrates with automated Travis builds
@jacobwgillespie
Copy link
Member Author

Okay, merge conflicts are resolved and this should be good to go

@jacobwgillespie jacobwgillespie mentioned this pull request Dec 15, 2015
@chrismou
Copy link
Member

Yo - haven't forgotten. Just getting a ./scripts/build-website.sh: line 5: bundle: command not found error, which I'm guessing is something to do with not having the right gems installed, maybe.

Trying to work it out now. If it is specific ruby gems that need installing, will these need specifying in the travis config?

@jacobwgillespie
Copy link
Member Author

Bundler is assumed to exist already (it's commonly installed with ruby) and is preinstalled on Travis. On your local machine, you can gem install bundler to grab a copy.

@jacobwgillespie
Copy link
Member Author

Oh, and once you have bundler installed, you run bundle install to install the other dependencies. Anyways, again this is something Travis does automatically.

@chrismou
Copy link
Member

Spent the past 2 minutes trying to work out what that notification sound was - turns out it was GitHub telling me you'd replied. This is what happens when I don't have music playing 😧

OK, will try that and report back shortly!

@chrismou
Copy link
Member

Oh and I went through the changelog - nice one logging the ticket. I'll push that up too when I'm done with this.

@jacobwgillespie
Copy link
Member Author

I just rebased this - you may need to re-pull

@chrismou
Copy link
Member

Will do 👍

@andrewnorell
Copy link
Contributor

I have a favicon.ico file to contribute once this PR is merged. :)

@chrismou
Copy link
Member

Only issue with the build process was @options[:href_ignore] will be renamed in a future 3.x.x release: http://git.io/vGHHy -- not sure if that's a Jekyll thing though

Aside from that, seems to be looking good. Though I'm making a mental note to rewrite that carousel to be pure CSS - the performance of that slick slider is awful.

:shipit:

@jacobwgillespie
Copy link
Member Author

That's the html test tool - we can fix later I think...

Merging!

@andrewnorell, ready for the favicon!

jacobwgillespie added a commit that referenced this pull request Dec 16, 2015
@jacobwgillespie jacobwgillespie merged commit a1bc09e into master Dec 16, 2015
@jacobwgillespie jacobwgillespie deleted the templatize-website branch December 16, 2015 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants