Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

status bar rating buttons fill fix #436

Merged
merged 1 commit into from
Dec 13, 2015

Conversation

chrismou
Copy link
Member

@chrismou chrismou commented Dec 8, 2015

Rating buttons in "now playing" status bar always showed as outlined even if thumbed up/down, due to an issue with a svg fill not working properly

Filled the background using css and the existing sprites

Fixes #429

@jacobwgillespie
Copy link
Member

Are those sprite URLs (like sprites_extended_d5d41cbe37133fce94c32acca2b8435c21125ddb.png) coming from Google? Feels like something that'd be easy to break if so. Maybe there's some way to dynamically detect the correct URL?

@chrismou
Copy link
Member Author

chrismou commented Dec 9, 2015

It's actually been playing on my mind that this was a bit of a short sighted solution. Though any method that uses the Google sprite sheet in our own custom css is probably a bad idea - I can't help feeling that it's just as likely they'll rearrange the sprite images as it is they'll rename the file (most likely, changing the sheet will trigger the rename at their end so either way, it's bound to break eventually).

I've ended up grabbing a copy of the sprite sheet to reference, so at least I know the image won't change.

I started playing with the idea of completely replacing those rating button graphics with our own, allowing for more control over colouring in custom themes (hence the commented out css) but I'm going to revisit this another time as part of a separate PR

@jacobwgillespie
Copy link
Member

This LGTM until it's revisited in another PR, so :shipit:

@chrismou chrismou force-pushed the thumbed-track-highlight branch 2 times, most recently from 50e5386 to 61813ef Compare December 13, 2015 02:01
@chrismou
Copy link
Member Author

Made a quick tweak to change the referenced image from http > https. For sanity's sake, I'll merge as soon as travis has done it's thing 👍

chrismou added a commit that referenced this pull request Dec 13, 2015
@chrismou chrismou merged commit ff77e26 into radiant-player:master Dec 13, 2015
@chrismou chrismou deleted the thumbed-track-highlight branch December 13, 2015 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants