This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Replace DDHidLib with custom version from BeardedSpice #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jacobwgillespie
force-pushed
the
fix-ddhidlib
branch
from
8f890ac
to
45dc1d8
Compare
|
Okay, @radiant-player/radiant-player-mac, this is building and is ready for review |
jacobwgillespie
force-pushed
the
fix-ddhidlib
branch
2 times, most recently
from
f0a4c14
to
1615865
Compare
|
@radiant-player/radiant-player-mac I'm going to merge this before too many people get a bad update. |
jacobwgillespie
added a commit
that referenced
this pull request
Dec 20, 2015
Replace DDHidLib with custom version from BeardedSpice
|
@jacobwgillespie A post-merge |
😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps out our stock DDHidLib framework with the custom version that BeardedSpice used to solve issue beardedspice/beardedspice#260. I can confirm that this solves the crash introduced in 1.6.0 and the media keys work, however as is reported in #203, the headset button still opens iTunes (in addition to controlling the player here).
I vote we merge this and release as 1.6.2 to fix the crash and then afterwards work on the iTunes issue.
Fixes #464