This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Don't hide when the main window is closed #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, OS X apps don't do this.
|
Awesome, thanks! |
jacobwgillespie
added a commit
that referenced
this pull request
Jan 14, 2016
Don't hide when the main window is closed
|
I don't see a difference. Out of interest, what has this changed? |
|
Before this patch, closing the main window "hid" Radiant as if you'd pressed command+H. The two main effects of hiding are…
It's interesting behavior, since a lot of the time when you close the main window you probably want to use another application, but it's pretty nonstandard and was confusing to me since I use the keyboard a lot (and would expect to be able to give keyboard input to Radiant after closing the main window or to switch to a specific app with command+tab). Hope that made sense! Let me know if it didn't. |
|
Ah OK I get it. Good spot, I'd never even noticed that before :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the first things I noticed when I started using Radiant. I've never seen an OS X app hide itself when you close its main window, and the behavior was pretty surprising! I hope to make more substantial contributions in the future 🎶.