Skip to content
This repository has been archived by the owner on Mar 30, 2021. It is now read-only.

Dark theme loading message colour #504

Merged
merged 1 commit into from
Feb 12, 2016

Conversation

chrismou
Copy link
Member

Missed this one yesterday. Just a tiny change to the loading message colour on dark themes to bring it in line with the header colours

@MarshallOfSound
Copy link

Just on a side note, if you guys have CSS files in your repo with hard coded colors it might be worth your time moving to a CSS preprocessor like LESS or SCSS so that you can just put variables everywhere for these colors.

Then you won't "miss" a colour like this again 😄

@chrismou
Copy link
Member Author

I've thought about stripping it all out into sass before, but I just know I'll end up escalating it into tidying up all the themes and there's other things I'd rather be spending time on. Like the gmusic integration or the electron branch!

Maybe I'll sort it some time soon. Just another thing to add to the ever growing list ;-)

@chrismou
Copy link
Member Author

Talking of gmusic.js, that's definitely next on the list...

@jacobwgillespie
Copy link
Member

👍

chrismou added a commit that referenced this pull request Feb 12, 2016
@chrismou chrismou merged commit d387f9a into radiant-player:master Feb 12, 2016
@chrismou chrismou deleted the fix/dark-theme-tweaks branch February 12, 2016 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants