Fix script warnings, remove style JS, simplify style loader

[jacobwgillespie]

Inspired by the console screenshots in #523, this PR should clear all the JS errors from our code (a few of them are coming from Google).

Changes:

• Fix errors where elements that don't exist are attempted to be modified
• Remove the addition of JS files per style (we aren't using this feature)
• Generally simplify the logic in the style loader

[chrismou]

Seeing as you fixed up all the console errors, I just clipped on a quick fix for the lastfm-icon error. Saves putting in another PR :-P

Otherwise LGTM 👍

[jacobwgillespie]

What do you think about leaving WebkitDeveloperExtras enabled? I feel like on 50% of the errors we get I have to enable it again, and on some of them we ask users to enable it. Seems like it could be a good idea just to leave it in the context menu.

[chrismou]

It's a fair point. TBF I never thought there was much value in switching it off, but seeing as we've always historically done it it's become a bit of a habit.

I've rebased my commit and re-added it 👍

[jacobwgillespie]

Sweet, merged

[BarakaAka1Only]

Just updated to 1.7.4 for "Fixed various JavaScript errors from Radiant’s scripts (#526)" and almost everything looks horrible tried all the styles that radiant-player comes with and it's the same

no buttons

UPDATE

went back to a older version to see if it was the same issue and yeah its happening still so i guess Google added/done something that is making the styling look so wrong

<img src=http://i.imgur.com/iwW5Hnd.png" />

but when going to music.google.com manually everything is fine there.

[jacobwgillespie]

What OS version are you using?

[BarakaAka1Only]

i am using Yosemite 10.10.5 it was working before i updated then that happened and i went back to the old version i was on (1.7.3) and its doing it there :S