Fix #7074: impactt app #7081
Merged
Fix #7074: impactt app #7081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @moellep |
moellep
requested changes
May 23, 2024
moellep
reviewed
May 24, 2024
|
@moellep ping |
moellep
approved these changes
May 30, 2024
There was a problem hiding this comment.
I made some changes with a76d2c6 - please give it a test and merge if it looks OK.
- Use RPNValue instead of Float in the schema
- Added default-data.json and a few changes to template.impactt so new sims can be created
- Updated the example to use the element positions from the lattice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.